TRD: correction for pile-up and update of error parametrization by glegras · Pull Request #15282 · AliceO2Group/AliceO2

glegras · 2026-04-15T16:01:28Z

No description provided.

shahor02 · 2026-04-15T22:19:44Z

+    auto& tRecord = (isTPCTRD ? mTrackTriggerRecordsTPCTRD[mCurrentTriggerRecord] : mTrackTriggerRecordsITSTPCTRD[mCurrentTriggerRecord]);
+    if (mCurrentTrackId >= tRecord.getFirstTrack() && mCurrentTrackId < tRecord.getFirstTrack() + tRecord.getNumberOfTracks()) {
+      uint32_t currentOrbit = tRecord.getBCData().orbit;
+      triggeredBC = tRecord.getBCData().bc + (currentOrbit - mFirstOrbit) * o2::constants::lhc::LHCMaxBunches;


you can use the method tRecord.getBCData().differenceInBC({0, mFirstOrbit});

shahor02 · 2026-04-15T22:22:19Z

+        }
+        if (o2::ft0::InteractionTag::Instance().isSelected(f0rec)) {
+          uint32_t currentOrbit = f0rec.getInteractionRecord().orbit;
+          triggeredBCFT0.push_back(f0rec.getInteractionRecord().bc + (currentOrbit - firstOrbit) * o2::constants::lhc::LHCMaxBunches);


idem, could be f0rec.getInteractionRecord().differenceInBC({0,firstOrbit})

shahor02 · 2026-04-15T22:28:17Z

+  int mPileUpRangeBefore{-130}; ///< maximal number of BC for which pile-up from previous collision has an influence
+  int mPileUpMaxProb{0};        ///< number of BC with respect to triggered BC for the event with maximal probability
+  int mPileUpRangeAfter{70};    ///< maximal number of BC for which pile-up from next collision has an influence


These numbers are different wrt those in the

AliceO2/GPU/GPUTracking/Definitions/GPUSettingsList.h

Lines 191 to 192 in 74098a4

AddOptionRTC(pileupFwdNBC, uint8_t, 80, "", 0, "Post-trigger Pile-up integration time in BCs")

AddOptionRTC(pileupBwdNBC, uint8_t, 80, "", 0, "Pre-trigger Pile-up integration time in BCs")

, used to define the timestamp errors of the track. Do we need to adjust them? In any case, would be better to avoid duplications.

alibuild · 2026-04-20T18:10:20Z

Error while checking build/O2/fullCI_slc9 for 0051b36 at 2026-04-20 20:10:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-04-22T18:04:09Z

Error while checking build/O2/fullCI_slc9 for f466afc at 2026-04-22 20:04:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/GPU/GPUTracking/TRDTracking/GPUTRDTracker.cxx:637:33: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/GPU/GPUTracking/TRDTracking/GPUTRDTracker.cxx:778:29: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TRD/qc/src/Tracking.cxx:125:22: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TRD/workflow/src/TRDGlobalTrackingSpec.cxx:416:22: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TRD/workflow/src/TRDGlobalTrackingSpec.cxx:845:22: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-05-15T14:19:34Z

Error while checking build/O2/fullCI_slc9 for d50274b at 2026-06-11 06:48:

## sw/BUILD/O2Physics-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-2/share/cmake-4.1/Modules/CMakeTestCCompiler.cmake:67 (message):
    ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/bcd6d7d51e9ba56cca5b52b3281a5c8817359f1e/slc9_x86-64/o2checkcode/1.0-local10/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='json-c MPFR UUID bz2 defaults-release Python-modules-list double-conversion pytorch_cpuinfo CMake ninja-fortran ninja safe_int Alice-GRID-Utils date googlebenchmark alibuild-recipe-tools FairCMakeModules O2-customization'
+ echo 'FULL_BUILD_REQUIRES=json-c MPFR UUID bz2 defaults-release Python-modules-list double-conversion pytorch_cpuinfo CMake ninja-fortran ninja safe_int Alice-GRID-Utils date googlebenchmark alibuild-recipe-tools FairCMakeModules O2-customization'
FULL_BUILD_REQUIRES=json-c MPFR UUID bz2 defaults-release Python-modules-list double-conversion pytorch_cpuinfo CMake ninja-fortran ninja safe_int Alice-GRID-Utils date googlebenchmark alibuild-recipe-tools FairCMakeModules O2-customization
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 10
+ REVISION_VALUE=10
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ '[' -z 10 ']'
+ echo 'json-c MPFR UUID bz2 defaults-release Python-modules-list double-conversion pytorch_cpuinfo CMake ninja-fortran ninja safe_int Alice-GRID-Utils date googlebenchmark alibuild-recipe-tools FairCMakeModules O2-customization'
+ tr '[:lower:]' '[:upper:]'
+ tr - _
[0 more errors; see full log]

Full log here.

shahor02 · 2026-06-17T08:22:54Z

+  int mPileUpMaxProb{0};        ///< number of BC with respect to triggered BC for the event with maximal probability
+  int mPileUpRangeAfter{70};    ///< maximal number of BC for which pile-up from next collision has an influence
+  // tracklets with Q0!=0 and Q1!=0
+  int mPileUpRangeBefore11{-130}; ///< maximal number of BC for which pile-up from previous collision has an influence


Should not these charge-dependent settings be derived from the mPileUpMaxProb/After ? Or have their own params in the GPU configurableParam? Unless one can treat them as detector constants.

shahor02 reviewed Apr 15, 2026

View reviewed changes

glegras marked this pull request as ready for review April 20, 2026 15:37

glegras requested review from bazinski, davidrohr, f3sch and wille10 as code owners April 20, 2026 15:37

glegras added 7 commits April 24, 2026 21:56

TRD: correction for pile-up

8eca6cb

clang format

df84537

small update

65e927c

clang format

54be31a

small fix

83911f5

move getPileUpProbTrack to the header

85c0920

fix checkcode errors

db38fa1

glegras added 2 commits June 16, 2026 10:49

update error parametrization

501f33d

clang format

b42cec9

glegras force-pushed the trdtracking branch from d50274b to b42cec9 Compare June 16, 2026 08:55

glegras changed the title ~~TRD: correction for pile-up~~ TRD: correction for pile-up and update of error parametrization Jun 16, 2026

shahor02 reviewed Jun 17, 2026

View reviewed changes

shahor02 approved these changes Jun 17, 2026

View reviewed changes

shahor02 merged commit 74675ef into AliceO2Group:dev Jun 17, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TRD: correction for pile-up and update of error parametrization#15282

TRD: correction for pile-up and update of error parametrization#15282
shahor02 merged 9 commits into
AliceO2Group:devfrom
glegras:trdtracking

glegras commented Apr 15, 2026

Uh oh!

shahor02 Apr 15, 2026

Uh oh!

shahor02 Apr 15, 2026

Uh oh!

shahor02 Apr 15, 2026

Uh oh!

alibuild commented Apr 20, 2026

Uh oh!

alibuild commented Apr 22, 2026

Uh oh!

alibuild commented May 15, 2026 •

edited

Loading

Uh oh!

shahor02 Jun 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

	AddOptionRTC(pileupFwdNBC, uint8_t, 80, "", 0, "Post-trigger Pile-up integration time in BCs")
	AddOptionRTC(pileupBwdNBC, uint8_t, 80, "", 0, "Pre-trigger Pile-up integration time in BCs")

Conversation

glegras commented Apr 15, 2026

Uh oh!

shahor02 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

shahor02 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

shahor02 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

alibuild commented Apr 20, 2026

Uh oh!

alibuild commented Apr 22, 2026

Uh oh!

alibuild commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahor02 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

alibuild commented May 15, 2026 •

edited

Loading